Improve compute build rust compilation error messaging
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamann
force-pushed
the
phamann/build-error-help
branch
from
4d162de
to
7982608
Compare
phamann
force-pushed
the
phamann/build-error-help
branch
from
7982608
to
8bbbe4f
Compare
thommahoney
approved these changes
May 11, 2020
Comment on lines
+175
to
+176
| "--color", | ||
| "always", |
There was a problem hiding this comment.
Not necessary for this PR, but if people start using this tool in CI, they may not want colors.
There was a problem hiding this comment.
Yup I thought about this too. I think we need to do a sweep on the commands in another PR to ensure we don't assume TTY, ANSI etc support.
thommahoney
reviewed
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improves the error messaging when Rust compilation fails during
fastly compute build.Why?
We've had lots of user feedback that the current implementation is confusing as it just returns an error code and no remediation message or help text. It was also not apparent that you could run the command with the
--verboseflag to get the full output from the childcargoprocess which contains the real cause of the failure.What
We now return the full buffered
stderroutput fromcargo buildif the process fails which hopefully gives the user much more information to solve their problem. We also pass the--verboseflag to the child process if supplied giving even more information if required.