Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds GCS logging endpoint support #62

Merged
merged 1 commit into from May 18, 2020
Merged

Adds GCS logging endpoint support #62

merged 1 commit into from May 18, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented May 8, 2020

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-gcs && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested a review from phamann May 8, 2020 13:29
mccurdyc
mccurdyc commented May 8, 2020
View reviewed changes
pkg/logging/gcs/create.go Outdated Show resolved Hide resolved
phamann
phamann reviewed May 11, 2020
View reviewed changes
pkg/logging/gcs/create.go Outdated Show resolved Hide resolved
phamann
phamann reviewed May 11, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor typo

@phamann phamann added the enhancement New feature or request label May 11, 2020
@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing into a single commit.

@mccurdyc mccurdyc requested a review from phamann May 13, 2020 19:18
phamann
phamann approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@mccurdyc mccurdyc changed the title logging: adds gcs logging endpoint logging: adds GCS logging endpoint May 14, 2020
@mccurdyc
logging: add GCS logging endpoint support
5cd8b88 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing upstream master.

@mccurdyc mccurdyc merged commit f5f5ff8 into fastly:master May 18, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-gcs branch May 18, 2020 13:19
@mccurdyc mccurdyc mentioned this pull request May 18, 2020
Merged
1 task
@mccurdyc mccurdyc changed the title logging: adds GCS logging endpoint Adds GCS logging endpoint May 21, 2020
@mccurdyc mccurdyc changed the title Adds GCS logging endpoint Adds GCS logging endpoint support May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mccurdyc @phamann