Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --force flag to compute build to skip verification steps. #68

Merged
merged 1 commit into from May 12, 2020

Conversation

phamann
Copy link
Member

@phamann phamann commented May 12, 2020

TL;DR

Adds a --force boolean flag to the fastly compute build command. This allows a user to skip the verification steps.

Why?

In #67 we introduced crate version verification which requires a network connection. Therefore, it is sensible to allow a user to skip this if offline. Or if they are a power user and understand the consequences of not verifying the local toolchain setup. Or if in CI environments you wish to use you alternative toolchain setup etc.

Copy link
Collaborator

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like having this as an all-encompassing flag rather than trying to make it language-specific.

@phamann phamann merged commit d15ed3b into master May 12, 2020
@phamann phamann deleted the phamann/force-build branch May 13, 2020 13:01
@phamann phamann added the enhancement New feature or request label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants