Add ability to exclude files from build package #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamann
force-pushed
the
phamann/package-files-ignore
branch
3 times, most recently
from
dbf8065
to
4ce16bb
Compare
peterbourgon
approved these changes
May 22, 2020
phamann
force-pushed
the
phamann/package-files-ignore
branch
from
2e614bb
to
fc06990
Compare
thommahoney
reviewed
May 26, 2020
phamann
force-pushed
the
phamann/package-files-ignore
branch
2 times, most recently
from
e33569e
to
d6b2bca
Compare
thommahoney
approved these changes
May 27, 2020
…vent files from being packaged via a .fastlyignore file.
phamann
force-pushed
the
phamann/package-files-ignore
branch
from
d6b2bca
to
b0308c8
Compare
phamann
force-pushed
the
phamann/package-files-ignore
branch
from
b0308c8
to
76a3b16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This adds two new features:
compute buildto not include thesrcdirectory in the package archive and add a--include-srcflag if desired..fastlyignorefile in the root of the project.Fixes #24.
Notes for reviewers:
I have renamed the existing
computeintegration style tests to a new filecompute_integration_test.gowhich tests the external command API and have created a newcompute_test.goto test the unexported (but still significant) functions within the package. Although I did agit mvthe diff isn't pleasant, so it's easier to review the new commit directly. 4ce16bb