Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fastly/invoice for v2 invoice endpoints #126

Merged
merged 1 commit into from
May 17, 2018
Merged

Update fastly/invoice for v2 invoice endpoints #126

merged 1 commit into from
May 17, 2018

Conversation

leklund
Copy link
Member

@leklund leklund commented May 4, 2018 •
edited
Loading

This updates the Invoice class to use the v2 endpoints and removes the deprecated endpoints.

  • adds list_invoices to retrieve a list of all invoices
  • adds get_invoice_by_id to get an invoice by id

@leklund leklund requested review from thommahoney and lanej May 15, 2018 18:48
@leklund leklund merged commit dfbb41f into master May 17, 2018
@leklund leklund deleted the billing_v2 branch May 17, 2018 16:45
blithe
blithe reviewed May 17, 2018
View reviewed changes
lib/fastly/invoice.rb
@@ -4,19 +4,7 @@
class Fastly
# An invoice for a time period
class Invoice < Base
attr_accessor :service_id, :service_name, :start_time, :end_time, :total, :regions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leklund it seems like this PR constitutes a breaking change so #127 should be a major bump.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. yep. I'll re-tag

@leklund leklund mentioned this pull request May 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blithe blithe blithe left review comments

@lanej lanej lanej approved these changes

@thommahoney thommahoney Awaiting requested review from thommahoney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leklund @lanej @blithe