👷➕🐛✅ fix tests in CI #134
Merged
👷➕🐛✅ fix tests in CI #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Gemfile: add rubocop. The Rakefile depended on rubocop test tasks, but we hadn't declared the dependency. * syslog test: fix stubbed URL * test_helper: require securerandom, which multiple tests use * Rakefile: use Rake::TestTask to define `test:unit` task. Previously this task was defined as a shell command but it didn't actually run any of the unit tests.
ryansouza
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test:unittask. Previously this task was defined as a shellcommand but it didn't actually run any of the unit tests.