Wrap test framework dependencies #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change to use Minitest instead of Test::Unit. It replaced Test::Unit
in the stdlib in v1.9, so might as well use it explicitly.
* Added a Fastly::TestCase class that wraps Minitest and updated
the existing classes to use this wrapper. This enables the framework
to be changed easily at a later date if required.
* Removed the inline calls to require RubyGems and Test::Unit.
* Removed the file munging for requiring {common,helper}.rb - using
Rake::TestTask sets the load path correctly and also allows
individual tests to be run.
* Added a test against the Minitest version to accommodate >= 5 for the
Fastly::TestCase class.
|
@sgerrand Sorry for the delay in getting back to you; This is really great - we typically use Minitest::Spec in-house and I've been getting around to switching this over as well; so this is definitely a great start. Merging now. |
set5think
pushed a commit
that referenced
this pull request
Apr 24, 2014
Wrap test framework dependencies and switch to minitest
|
👍 |
|
No worries. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 The intent of these changes is twofold:
Fastly::TestCaseclass so thatTest::Unitcan be more easily swapped out forMinitestFollowing on from these changes, I intend to add unit tests for the library classes themselves to complement the existing integration tests. I'm interested in getting feedback though, so please let me know if these changes are in tune with the project's intent.