Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tls client auth for syslog #139

Merged
merged 3 commits into from Jan 6, 2020
Merged

Add support for tls client auth for syslog #139

merged 3 commits into from Jan 6, 2020

Conversation

laramackey
Copy link
Contributor

@laramackey laramackey commented Dec 5, 2019 •
edited

Addresses #137

@laramackey laramackey marked this pull request as ready for review December 6, 2019 12:02
@laramackey
Copy link
Contributor Author

Hey @philippschulte !

Are you, or anyone from the Fastly team able to review this? It would be useful for getting our syslog endpoints fully automated in terraform.

philippschulte
philippschulte requested changes Dec 12, 2019
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laramackey thanks for your contribution! Please use camelCase for all your variables. Please don't modify the recordings manually. You'll need to run the test suite in order to create new recordings. You can find detailed instructions on how to run the suite here.

We already have a private key in fastly_test.go. Please add your certificate to the global test file so that we can use it in other test files if necessary. If you need to replace the existing key then please create new recordings for all resources who use the key. Please let me know if you have any further questions. Thanks

@laramackey
Copy link
Contributor Author

Hi @philippschulte thank you for your help (and happy new year)

I've changed the variable casing, added the private key and cert in fastly_test.go and have run the test suites to create recordings for TestClient_Bigqueries and TestClient_Syslogs in b13a4ad

philippschulte
philippschulte approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A happy new year and thank you for your contribution!

@philippschulte philippschulte merged commit 50792f5 into fastly:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laramackey @philippschulte