Add support for compression_codec to logging file sink endpoints #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmorrow
reviewed
Dec 8, 2020
|
Thanks for the PR! There's a couple of other PRs from @kellymclaughlin that I need to catch back up on (since I've been on paternity leave), so those will take priority for me today. Hopefully I can find some time later today to review this PR though. |
|
@kellymclaughlin @jaredmorrow am I right in noticing that the new field |
Integralist
reviewed
Dec 9, 2020
Update the tests for logging endpoints that have the compression_codec option to exercise the interaction between compression_codec and gzip_level.
Integralist
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for compression_codec to the following logging endpoints in go-fastly:
gzip_levelis still supported, butcompression_codecis now the preferred option. The intention is that ifgzip_levelis present it overrides anycompression_codecvalue.