Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic managed logging endpoint support to go-fastly #241

Merged
merged 2 commits into from Jan 11, 2021

Conversation

jaredmorrow
Copy link
Contributor

@jaredmorrow jaredmorrow commented Jan 5, 2021

Support enabling and disabling managed logging for a service.

@Integralist
Copy link
Collaborator

Integralist commented Jan 6, 2021

@jaredmorrow I'm guessing this error is because you need to have that feature enabled on your account for the VCR fixture to work? I stand corrected, I just reviewed the changes and looks like the fixtures were generated correctly. 🤔

--- FAIL: TestClient_ManagedLogging (0.21s)
    managed_logging_test.go:27: 401 - Unauthorized:
        
            Title:  Provided credentials are missing or invalid

@jaredmorrow
Copy link
Contributor Author

@Integralist That was my initial concern / thought as well. I didn't think it was needed, but I still added the test service 7i6HN3TK9wS159v2gPAZ8A to the feature in question in Fastly App -> Admin.

@jaredmorrow
Copy link
Contributor Author

@Integralist it was a case issue. I switched to underscore to match the rest of the fixtures. Now it works.

@jaredmorrow jaredmorrow marked this pull request as draft January 7, 2021 14:32
Support enabling and disabling managed logging for a service.
@jaredmorrow jaredmorrow marked this pull request as ready for review January 7, 2021 19:39
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaredmorrow for opening this PR (and thank you for your patience waiting for a review!). I've a couple of comments/suggested tweaks.

fastly/fixtures/managed_logging/recreate.yaml Show resolved Hide resolved
fastly/managed_logging.go Outdated Show resolved Hide resolved
fastly/fixtures/managed_logging/delete.yaml Show resolved Hide resolved
@jaredmorrow jaredmorrow merged commit 6d7e902 into master Jan 11, 2021
@jaredmorrow jaredmorrow deleted the jm/managed_logging branch January 11, 2021 15:42
@Integralist Integralist added the enhancement New feature or request label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants