Support for Service Authorizations #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noseglid
force-pushed
the
service-authorization
branch
2 times, most recently
from
cd50287
to
6b72cc6
Compare
Integralist
requested changes
Jun 16, 2022
There was a problem hiding this comment.
Hi @noseglid 👋🏻
Thank you for opening this PR. It's really appreciated.
For the sake of consistency with the rest of the code base I've requested some changes to help keep the code aligned.
noseglid
commented
Jun 16, 2022
When a user has the "engineer" level, specific access to specific services can be granted using service authorizations. This change adds support for creating, retrieving, updating and deleting service authorizations using the Go client.
We can use the string directly instead of creating new types for permissions and data types as we do not require any extra functionality on these types.
noseglid
force-pushed
the
service-authorization
branch
from
8053d3b
to
e172702
Compare
noseglid
commented
Jun 16, 2022
Using `jsonapi` saves us from constructing a lot of extra models because the API provided by fastly already follows the conventions outlined by `jsonapi`.
Anonymizes the IDs used for service authorizations as well as adds a new "default" id for user, which can be anonymized to a default User ID in the `fix-fixtures` target of the makefile.
noseglid
force-pushed
the
service-authorization
branch
from
e172702
to
c508116
Compare
Add Godocs to the exposed functions and structs used as inputs.
Integralist
reviewed
Jun 17, 2022
There was a problem hiding this comment.
Thanks @noseglid this is looking a lot better. Just a few small comments. Thanks!
Only the serviceid needs to be default and normalized.
noseglid
force-pushed
the
service-authorization
branch
from
6eb50fb
to
d9bf2fa
Compare
Instead of re-using amibuous error messages, create and use a dedicated error when CreateServiceAuthorization is used incorrectly.
noseglid
force-pushed
the
service-authorization
branch
from
d9bf2fa
to
3b516a2
Compare
|
I have now addressed all your comments |
Integralist
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Made two suggested edits (which I'll apply in a moment), but otherwise this looks good to me.
Thanks @noseglid 🙂
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has the "engineer" level, specific access to specific
services can be granted using service authorizations.
This change adds support for creating, retrieving, updating and deleting
service authorizations using the Go client.