Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secret Store API support #367

Merged
merged 2 commits into from Oct 5, 2022
Merged

Conversation

awilliams-fastly
Copy link
Collaborator

Secret Store is currently part of a beta release.

https://developer.fastly.com/reference/api/secret-store/

Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fastly/errors_test.go Outdated Show resolved Hide resolved
fastly/errors.go Show resolved Hide resolved
fastly/secret_store.go Outdated Show resolved Hide resolved
fastly/secret_store.go Show resolved Hide resolved
Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awilliams-fastly awilliams-fastly merged commit fe76cf1 into main Oct 5, 2022
@awilliams-fastly awilliams-fastly deleted the awilliams/secret-store branch October 5, 2022 18:23
@Integralist Integralist added the enhancement New feature or request label Oct 6, 2022
@chenrui333
Copy link
Contributor

Any idea when this would be supported in the provider side?

awilliams-fastly added a commit that referenced this pull request Nov 15, 2022
Instead of panic'ing when an error response cannot be decoded from JSON,
return a generic error which includes the read portion of the response
body.

Followup to @dgryski's comment:
#367 (comment)
awilliams-fastly added a commit that referenced this pull request Nov 16, 2022
Instead of panic'ing when an error response cannot be decoded from JSON,
return a generic error which includes the read portion of the response
body.

Followup to @dgryski's comment:
#367 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants