Secret Store: Support PUT & PATCH methods when creating secret
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method controls the behavior when creating a secret with a name that already exists in the store. - `POST`: Default. Create a secret and error if one already exists with the same name. - `PUT`: Create or recreate a secret. - `PATCH`: Recreate a secret and error if one does not already exist with the same name.
awilliams-fastly
added a commit
to fastly/cli
that referenced
this pull request
May 10, 2023
This works in combination with fastly/go-fastly#433 which adds support for the `CreateSecretInput.Method` field. Secret names must be unique within a store. The method effects how duplicate names are handled: - `POST`: Default. Create a secret and error if one already exists with the same name. - `PUT` / `--recreate`: Create or recreate a secret. - `PATCH` / `--recreate-must`: Recreate a secret and error if one does not already exist with the same name.
Integralist
approved these changes
May 11, 2023
awilliams-fastly
added a commit
to fastly/cli
that referenced
this pull request
May 26, 2023
This works in combination with fastly/go-fastly#433 which adds support for the `CreateSecretInput.Method` field. Secret names must be unique within a store. The method effects how duplicate names are handled: - `POST`: Default. Create a secret; error if one already exists with the same name. - `PUT` / `--recreate`: Create or recreate a secret. - `PATCH` / `--recreate-must`: Recreate a secret and error if one does not already exist with the same name.
awilliams-fastly
added a commit
to fastly/cli
that referenced
this pull request
May 26, 2023
This works in combination with fastly/go-fastly#433 which adds support for the `CreateSecretInput.Method` field. Secret names must be unique within a store. The method effects how duplicate names are handled: - `POST`: Default. Create a secret; error if one already exists with the same name. - `PUT` / `--recreate-allow`: Create or recreate a secret. - `PATCH` / `--recreate`: Recreate a secret and error if one does not already exist with the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method controls the behavior when creating a secret with a name that already exists in the store.
POST: Default. Create a secret and error if one already exists with the same name.PUT: Create or recreate a secret.PATCH: Recreate a secret and error if one does not already exist with the same name.