feat(config store): adds ListConfigStoresInput #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figStores The addition of the ListConfigStoresInput allows for using the `name` param when retrieving a list of config stores.
Integralist
reviewed
Nov 7, 2023
| // ListConfigStores returns a list of config stores sorted by name. | ||
| func (c *Client) ListConfigStores() ([]*ConfigStore, error) { | ||
| func (c *Client) ListConfigStores(i *ListConfigStoresInput) ([]*ConfigStore, error) { |
There was a problem hiding this comment.
This will result in a breaking interface change and a major release. Are we ok with doing that? If we're going to be pushing a breaking change we should check what else we can roll up into that release that is also breaking.
Integralist
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameparam when retrieving a list of config stores.