Add support for specifying location when creating KV stores #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hrmsk66 Thanks for opening this PR. Would be good to also get a PR opened for the CLI 馃檪 |
Integralist
approved these changes
Apr 16, 2024
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 This PR adds the ability to specify the location when creating a new KV store using the API. I would like terraform-provider-fastly to support specifying the location for KV stores, and this change is a preparation for that.
Changes made:
Locationfield to theCreateKVStoreInputstruct.CreateKVStoremethod to include the location parameter in the API request if it is provided in the input struct.TestClient_CreateKVStoresWithLocationsto verify that KV stores can be created with different locations.