add placement field to all missing providers #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add placement field to ftp, gcs, logentries, papertrail, s3, sumologic, and syslog
philippschulte
deleted the
add-placement-field-to-all-missing-logging-providers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each logging provider supports the
placementfield in order to place the logging call in a specific VCL subroutine. Two related PRs have been already merged:The problem with these two PRs is that only the response struct or the request structs have been updated in order to accept the
placementfield. This PR adds theplacementfield to all structs of each logging provider.This PR is necessary to be able to support the
placementfunctionality in theTerraformprovider. Here is the link to the corresponding Terraform PR for more information.