fix: If request does not have a static backend defined, return `undef…

…ined` for the Request.prototype.backend getter This fixes #716
fastly · Jan 25, 2024 · c38e288 · c38e288
1 parent 17fbdf5
commit c38e288
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/runtime/js-compute-runtime/builtins/request-response.cpp b/runtime/js-compute-runtime/builtins/request-response.cpp
@@ -1263,11 +1263,7 @@ bool Request::bodyAll(JSContext *cx, unsigned argc, JS::Value *vp) {
 bool Request::backend_get(JSContext *cx, unsigned argc, JS::Value *vp) {
   METHOD_HEADER(0)
   JS::RootedValue backend(cx, JS::GetReservedSlot(self, static_cast<uint32_t>(Slots::Backend)));
-  if (backend.isNullOrUndefined()) {
-    args.rval().setString(JS_GetEmptyString(cx));
-  } else {
-    args.rval().set(backend);
-  }
+  args.rval().set(backend);
 
   return true;
 }
@@ -1990,7 +1986,8 @@ JSObject *Request::create(JSContext *cx, JS::HandleObject requestInstance, JS::H
   // (implicit)
 
   // Apply the Fastly Compute-proprietary `backend` property.
-  if (!backend_val.isUndefined()) {
+  if (!backend_val.isNullOrUndefined()) {
+    dump_value(cx, backend_val, stdout);
     JS::RootedString backend(cx, JS::ToString(cx, backend_val));
     if (!backend) {
       return nullptr;

diff --git a/types/globals.d.ts b/types/globals.d.ts
@@ -1084,7 +1084,7 @@ interface Request extends Body {
   clone(): Request;
 
   // Fastly extensions
-  backend: string;
+  backend?: string;
   setCacheOverride(override: import('fastly:cache-override').CacheOverride): void;
   setCacheKey(key: string): void;
   setManualFramingHeaders(manual: boolean): void;