Skip to content

Commit

Permalink
fix: update to latest url crate which passes some more wpt url tests
Browse files Browse the repository at this point in the history
  • Loading branch information
JakeChampion committed Aug 10, 2023
1 parent 8da6a03 commit f0a42fd
Show file tree
Hide file tree
Showing 6 changed files with 46 additions and 39 deletions.
28 changes: 14 additions & 14 deletions runtime/js-compute-runtime/rust-url/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion runtime/js-compute-runtime/rust-url/Cargo.toml
Expand Up @@ -7,4 +7,11 @@ edition = "2018"
crate-type = ["staticlib"]

[dependencies]
url = "2.3.1"
url = "2.4.0"

[profile.release]
lto = true
panic = 'abort'

[profile.dev]
panic = 'abort'
24 changes: 12 additions & 12 deletions tests/wpt-harness/expectations/url/url-constructor.any.js.json
Expand Up @@ -1911,40 +1911,40 @@
"status": "PASS"
},
"Parsing: <non-spec:/.//> without base": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <non-spec:/..//> without base": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <non-spec:/a/..//> without base": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <non-spec:/.//path> without base": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <non-spec:/..//path> without base": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <non-spec:/a/..//path> without base": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: </.//path> against <non-spec:/p>": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: </..//path> against <non-spec:/p>": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <..//path> against <non-spec:/p>": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <a/..//path> against <non-spec:/p>": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <> against <non-spec:/..//p>": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <path> against <non-spec:/..//p>": {
"status": "FAIL"
"status": "PASS"
},
"Parsing: <../path> against <non-spec:/.//p>": {
"status": "PASS"
Expand Down
18 changes: 9 additions & 9 deletions tests/wpt-harness/expectations/url/url-setters.any.js.json
Expand Up @@ -453,10 +453,10 @@
"status": "PASS"
},
"URL: Setting <non-spec:/.//p>.hostname = 'h' Drop /. from path": {
"status": "PASS"
"status": "FAIL"
},
"URL: Setting <non-spec:/.//p>.hostname = ''": {
"status": "PASS"
"status": "FAIL"
},
"URL: Setting <http://example.com/>.hostname = '///bad.com' Leading / is not stripped": {
"status": "PASS"
Expand Down Expand Up @@ -633,7 +633,7 @@
"status": "FAIL"
},
"URL: Setting <non-spec:/.//>.pathname = 'p' Drop /. from path": {
"status": "PASS"
"status": "FAIL"
},
"URL: Setting <data:/nospace>.pathname = 'space ' Non-special URLs with non-opaque paths percent-encode U+0020": {
"status": "FAIL"
Expand Down Expand Up @@ -678,16 +678,16 @@
"status": "PASS"
},
"URL: Setting <data:space ?query>.search = '' Drop trailing spaces from trailing opaque paths": {
"status": "FAIL"
"status": "PASS"
},
"URL: Setting <sc:space ?query>.search = ''": {
"status": "FAIL"
"status": "PASS"
},
"URL: Setting <data:space ?query#fragment>.search = '' Do not drop trailing spaces from non-trailing opaque paths": {
"status": "PASS"
"status": "FAIL"
},
"URL: Setting <sc:space ?query#fragment>.search = ''": {
"status": "PASS"
"status": "FAIL"
},
"URL: Setting <http://example.net>.search = ' ' Trailing space should be encoded": {
"status": "PASS"
Expand Down Expand Up @@ -744,10 +744,10 @@
"status": "PASS"
},
"URL: Setting <data:space #fragment>.hash = '' Drop trailing spaces from trailing opaque paths": {
"status": "FAIL"
"status": "PASS"
},
"URL: Setting <sc:space #fragment>.hash = ''": {
"status": "FAIL"
"status": "PASS"
},
"URL: Setting <data:space ?query#fragment>.hash = '' Do not drop trailing spaces from non-trailing opaque paths": {
"status": "PASS"
Expand Down
Expand Up @@ -12,10 +12,10 @@
"status": "PASS"
},
"Changing the query of a URL with an opaque path can impact the path": {
"status": "FAIL"
"status": "PASS"
},
"Changing the query of a URL with an opaque path can impact the path if the URL has no fragment": {
"status": "PASS"
"status": "FAIL"
},
"Two-argument delete()": {
"status": "FAIL"
Expand Down
2 changes: 1 addition & 1 deletion tests/wpt-harness/wpt
Submodule wpt updated 1384 files

0 comments on commit f0a42fd

Please sign in to comment.