Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error during wizening for async functions given to addEventListener #687

Closed
elliottt opened this issue Oct 9, 2023 · 0 comments · Fixed by #689
Closed

Raise an error during wizening for async functions given to addEventListener #687

elliottt opened this issue Oct 9, 2023 · 0 comments · Fixed by #689

Comments

@elliottt
Copy link
Contributor

elliottt commented Oct 9, 2023

addEventListener must not be given an async function, as this will terminate execution at the first await encountered. Instead, the function given as the callback must be rewritten as e => e.respondWith(async_function(e)). We can detect this during wizening, and instead raise an error that indicates how to fix the problem, rather than delay the error to when a request is being handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant