feature: implement setTimeout, setInterval, clearTimeout, and clearInterval #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/generic-select
branch
3 times, most recently
from
6b544fe
to
7de0b1a
Compare
elliottt
reviewed
Oct 25, 2022
JakeChampion
force-pushed
the
jake/generic-select
branch
8 times, most recently
from
874a89e
to
63aa466
Compare
|
@elliottt this is ready for another rounds of reviews -- I also used the version of Viceroy which has implementations for the |
JakeChampion
force-pushed
the
jake/generic-select
branch
3 times, most recently
from
7550146
to
b079f76
Compare
|
This is currently blocked on a new version of Viceroy which includes the Once that pull-request is merged and released, we can update our version of Viceroy and should then see all the tests pass on this PR 👍 |
This was referenced Oct 28, 2022
Closed
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.65 to 1.0.66. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.65...1.0.66) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Trevor Elliott <telliott@fastly.com>
Co-authored-by: Trevor Elliott <telliott@fastly.com>
…mers` is not empty before calling `repeat_first`
JakeChampion
force-pushed
the
jake/generic-select
branch
from
7a406c7
to
4071e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new fastly_async_io module we can implement JS timers 🥳
This pull-request implements setTimeout, setInterval, clearTimeout, and clearInterval and adds some interface and basic tests for them. There are also tests in the web-platform-tests that exercise the functions fully, which is why I only needed to write some basic tests.
Currently Viceroy does not have a host implementation for fastly_async_io so for now our tests can only run in production.
Closes #63