fix: When converting a URL to a string, do not add a ? if there are no query string parameters
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/urlsearchparams
branch
2 times, most recently
from
4462ee6
to
314a4c2
Compare
JakeChampion
commented
Apr 11, 2023
| pairs.clear().extend_pairs(self.list.iter()); | ||
| match self.list.is_empty() { | ||
| true => { | ||
| url.url.set_query(None); |
There was a problem hiding this comment.
This is the crux of the bug-fix.
Previously we used url.query_pairs_mut().clear() however url.query_pairs_mut().clear(); is equivalent to url.set_query(Some("")), not url.set_query(None) and we really wanted .set_query(None)
guybedford
approved these changes
Apr 11, 2023
elliottt
approved these changes
Apr 11, 2023
| @@ -36,13 +36,26 @@ impl JSUrlSearchParams { | |||
| match self.url_or_str { | |||
| UrlOrString::Url(url) => { | |||
| let url = unsafe { url.as_mut().unwrap() }; | |||
| let mut pairs = url.url.query_pairs_mut(); | |||
| pairs.clear().extend_pairs(self.list.iter()); | |||
| match self.list.is_empty() { | |||
There was a problem hiding this comment.
Could you switch this to an if-then-else, as it's matching a bool value?
JakeChampion
force-pushed
the
jake/urlsearchparams
branch
from
314a4c2
to
bc4d892
Compare
… no query string parameters fixes #484
JakeChampion
force-pushed
the
jake/urlsearchparams
branch
from
bc4d892
to
8d6069f
Compare
|
Hi all -- is this live on fastly production services? |
Howdy, yes version 1.7.1 has this included 👍 https://github.com/fastly/js-compute-runtime/blob/main/CHANGELOG.md#171-2023-04-11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #484