Replace spidermonkey-wasi-embedding submodule with gecko-dev #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that contributions which require modifying our branch of gecko-dev, don't require having to edit 3 repositories, and instead just 2 (gecko-dev and this repo).
We do currently lose prebuilt spidermonkey-wasi builds, which does mean a contributor will need to clone and compile gecko-dev. I've added a script which will install the required dependencies for gecko-dev, named
install-gecko-dependencies.sh
, and also updated our Makefile to compile gecko-dev.make
will compile gecko-dev and js-compute-runtime, both in release modeDEBUG=true make
will compile gecko-dev and js-compute-runtime, both in debug mode