Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spidermonkey-wasi-embedding submodule with gecko-dev #633

Closed
wants to merge 2 commits into from

Conversation

JakeChampion
Copy link
Member

This change makes it so that contributions which require modifying our branch of gecko-dev, don't require having to edit 3 repositories, and instead just 2 (gecko-dev and this repo).

We do currently lose prebuilt spidermonkey-wasi builds, which does mean a contributor will need to clone and compile gecko-dev. I've added a script which will install the required dependencies for gecko-dev, named install-gecko-dependencies.sh, and also updated our Makefile to compile gecko-dev.

make will compile gecko-dev and js-compute-runtime, both in release mode
DEBUG=true make will compile gecko-dev and js-compute-runtime, both in debug mode

@JakeChampion JakeChampion force-pushed the jake/simpler branch 8 times, most recently from ef40bd0 to a4b944a Compare August 24, 2023 16:20
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping the runtime/spidermonkey directory so that the build happens in a completely different tree? I think we should still try to make it easy to keep the two codebases separate so that we stick to the embedder api.

@JakeChampion JakeChampion deleted the jake/simpler branch September 11, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants