Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add fmtlib #659

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore: Add fmtlib #659

merged 1 commit into from
Sep 13, 2023

Conversation

elliottt
Copy link
Contributor

@elliottt elliottt commented Sep 13, 2023 •
edited
Loading

Add a submodule for fmtlib 10.1.1 and port some uses of string concatenation to
fmt::format instead.

If we start using fmtlib in any of the shared builtins, we'll need to ensure that the third_party/fmt/src/format.o file gets included when we construct shared.a.

JakeChampion
JakeChampion approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@JakeChampion JakeChampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@elliottt elliottt merged commit 3b97363 into main Sep 13, 2023
81 checks passed
@elliottt elliottt deleted the trevor/fmtlib branch September 13, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elliottt @JakeChampion