Complete StarlingMonkey SDK Tests #807
Conversation
| @@ -548,7 +548,6 @@ bool CacheEntry::body(JSContext *cx, unsigned argc, JS::Value *vp) { | |||
| // options parameter is optional | |||
| // options is meant to be an object with an optional `start` and `end` fields, both which can be | |||
| // Numbers. | |||
| dump_value(cx, options_val, stdout); | |||
There was a problem hiding this comment.
This seems like a log that was included previously as an oversight.
guybedford
changed the title
guybedford
changed the title
| if: steps.cache-crate.outputs.cache-hit != 'true' | ||
|
|
||
| run_wpt: | ||
| if: github.ref != 'refs/heads/main' && false |
There was a problem hiding this comment.
This adds the WPT test suite to CI, but disabled for now as there are still 100 tests failing. Will post fixes in a follow-up.
| return Request::is_instance(obj) || Response::is_instance(obj) || | ||
| SimpleCacheEntry::is_instance(obj) || KVStoreEntry::is_instance(obj) || | ||
| CacheEntry::is_instance(obj); | ||
| return Request::is_instance(obj) || Response::is_instance(obj) || KVStoreEntry::is_instance(obj); |
There was a problem hiding this comment.
Why remove SimpleCacheEntry and CacheEntry?
There was a problem hiding this comment.
Right now, the js-compute-runtime build does not test its own debug build for the SDK tests, and I originally added these to the StarlingMonkey port fix assertions that were failing for the debug build, but it turns out it changes streaming behaviour which was the root cause of the remaining test. Thus switching from the debug build to the release build and reverting these changes was the required fix.
We should follow-up with a separate PR to reenable debug builds for the SDK tests, where we should then fix the assertions both for the existing runtime and the StarlingMonkey port.
|
To be clear - the current js-compute-runtime debug build does not pass the SDK tests, which was the root cause of this fix. |
This completes the StarlingMonkey SDK test suite, enabling all of the tests for the StarlingMonkey build and on CI.
We still need to enable the WPT though, which still has tests outstanding.
In the process a new test filtering command has been added making it possible to run local integration tests via
npm run test:integration -- --starlingmonkey --local test-namefor example.