Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CompressionStream builtin #84

Merged
merged 2 commits into from May 3, 2022
Merged

Conversation

tschneidereit
Copy link
Contributor

This adds an implementation of and test expectations for the CompressionStream builtin allowing for compression of buffers or streams using the gzip or deflate compression formats.

Some of the changes involve how streams interact with host-side bodies, and fix some issues uncovered through tests of compression streams, that didn't otherwise show up.

This adds an implementation of and test expectations for the [CompressionStream](https://wicg.github.io/compression/#compression-stream) builtin allowing for compression of buffers or streams using the gzip or deflate compression formats.
@tschneidereit tschneidereit requested a review from cfallin May 2, 2022 23:37
Copy link
Contributor

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, just one uncertainty below related to the compression loop:

Copy link
Contributor

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for the clarifications!

@tschneidereit tschneidereit merged commit 351268d into main May 3, 2022
@tschneidereit tschneidereit deleted the compression-stream branch May 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants