move client request handler into core::http1::client #47979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-fastly
reviewed
May 1, 2024
sima-fastly
reviewed
May 1, 2024
sima-fastly
reviewed
May 1, 2024
sima-fastly
reviewed
May 1, 2024
sima-fastly
reviewed
May 1, 2024
sima-fastly
reviewed
May 1, 2024
sima-fastly
reviewed
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the HTTP client code from src/connection.rs into a new module next to the new server module. With the new module naming,
connection::ClientRequestbecomescore::http1::client::Request. Unlike the new server module, this client module is actually used. This PR removes the code from src/connection.rs, adds the new module, and updates all references to refer to the new module. Only very minor changes were made along the way, basically enough to make it work in the new location (renaming types, marking types/fns aspub, wrapping field access with methods, etc).