Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.0 Breaks concurrency #321

Closed
dbraley opened this issue Oct 9, 2023 · 3 comments · Fixed by #322
Closed

0.9.0 Breaks concurrency #321

dbraley opened this issue Oct 9, 2023 · 3 comments · Fixed by #322

Comments

@dbraley
Copy link

dbraley commented Oct 9, 2023

Hello! A number of our engineers use viceroy through the fastly-cli for local development. This morning, a number of them were upgraded to v0.9.0 and immediately had their environments stop working. It seems that any request that is made concurrently with another ongoing request is getting the following error:

thread ‘tokio-runtime-worker’ panicked at lib/src/execute.rs:282:27:
failed to run guest: Error instantiating WebAssembly: maximum concurrent memory limit of 1 reached

I seem to recall it being 100 at some point in time, when we had to throttle certain types of requests, if that helps. I suspect it's a configurable value, but have no idea where it is configured.

I have confirmed that if I use viceroy v0.8.1 this does not happen.

@elliottt
Copy link
Contributor

elliottt commented Oct 9, 2023

This was introduced with the wasmtime 13.0.0 upgrade: the total number of memories configured in the pooling allocator should have matched the maximum number of core instances.

@dbraley
Copy link
Author

dbraley commented Oct 9, 2023

Awesome, thank you for the fast turn around on that! Look forward to testing it out 🎉

@dbraley
Copy link
Author

dbraley commented Oct 10, 2023

Works great, thanks! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants