Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handlers for SMFIR_ADDRCPT, SMFIR_DELRCPT and SMFIR_CHGFROM #130

Closed
wants to merge 1 commit into from

Conversation

bokutin
Copy link
Contributor

@bokutin bokutin commented Sep 17, 2022

Hello.

I modified it to do the postsrsd equivalent process with milter.

It was easy because authentication_milter itself is well structured.

It works well in my environment.

I would be happy to merge it if it is useful.

However, there is no test, and if you are worried about maintenance, you don't have to merge it.
In that case, please reject and close.

Thanks.

@marcbradshaw
Copy link
Member

My main issue here is there is no associated change in the SMTP protocol handler, so running this in SMTP mode will result in methods being called which do not exist. This is a reasonable feature, but needs SMTP support and tests.

@bokutin
Copy link
Contributor Author

bokutin commented Oct 6, 2022

You are right. Thanks for the reply!

@bokutin bokutin closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants