Or type fix #1557
Merged
Or type fix #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitu
reviewed
Dec 5, 2023
|
Eagerly awaiting this getting done! |
amitu
reviewed
Dec 7, 2023
amitu
reviewed
Dec 7, 2023
|
@harshdoesdev tests are failing. |
It should be resolved now |
|
@Arpita-Jaiswal, @Heulitig what do you think? |
|
The build for fastn.com was failing on my system, even when using a
different build of fastn. This was due to network issues. I will test it
again and let you know
…On Fri, 8 Dec, 2023, 9:55 pm Amit Upadhyay, ***@***.***> wrote:
@Arpita-Jaiswal <https://github.com/Arpita-Jaiswal>, @Heulitig
<https://github.com/Heulitig> what do you think?
—
Reply to this email directly, view it on GitHub
<#1557 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APOETAS4Z2VYGF5N5VDQIY3YIM5RLAVCNFSM6AAAAABAHKK4DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXGQ3TSMZSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
harshdoesdev
force-pushed
the
or-type-fix
branch
from
854f645
to
71ee355
Compare
Arpita-Jaiswal
approved these changes
Dec 11, 2023
|
@harshdoesdev though I have added some comments but we can go with this for now. In subsequent PR, can we make the changes I have suggested? |
Arpita-Jaiswal
previously approved these changes
Dec 11, 2023
amitu
reviewed
Dec 11, 2023
amitu
reviewed
Dec 11, 2023
amitu
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.