fix: Module reference issue with or-type variant

[harshdoesdev]

It fixes an issue where property values were not being wrapped in their respective or-type when a reference value was assigned to a property by referencing it from a header module. In the below example, the $page.colors.base- was not being wrapped in the or-type fastn_dom.BackgroundStyle.Solid, but $colors.base- was properly being wrapped in the or-type. Due to this the background color for the first column was not changing where the value was not wrapped in its respective or-type.

-- import: 08-inherited as colors

-- component page:
module colors: colors

-- ftd.column:
width: fill-container
height: fill-container
background.solid: $page.colors.base-

-- ftd.text: Hello world

-- ftd.column:
width: fill-container
height: fill-container
background.solid: $colors.base-

-- ftd.text: Hello world

-- end: ftd.column

-- end: ftd.column

-- end: page

-- page:

[amitu]

@Arpita-Jaiswal, what to do with this PR?

[amitu]

@harshdoesdev what do we do with this PR? Is it still needed? Ready?

[harshdoesdev]

@harshdoesdev what do we do with this PR? Is it still needed? Ready?

Yes @amitu, this PR is complete. It fixes an issue where property values were not being wrapped in their respective or-type when a reference value was assigned to a property by referencing it from a header module. In the below example, the $page.colors.base- was not being wrapped in the or-type fastn_dom.BackgroundStyle.Solid but $colors.base- was properly being wrapped in the or-type. Due to this the background color for the first column was not changing where the value was not wrapped in its respective or-type.

-- import: 08-inherited as colors

-- component page:
module colors: colors

-- ftd.column:
width: fill-container
height: fill-container
background.solid: $page.colors.base-

-- ftd.text: Hello world

-- ftd.column:
width: fill-container
height: fill-container
background.solid: $colors.base-

-- ftd.text: Hello world

-- end: ftd.column

-- end: ftd.column

-- end: page

-- page:

[amitu]

@harshdoesdev I was expecting something like this:

what do we do with this PR?

Merge this PR.

Is it still needed?

Yes

Ready?

Yes, this PR is ready from my side.

You have used a lot of words and managed to not answer any of my questions :-p

[harshdoesdev]

It fixes an issue where property values were

Yes, @amitu, this pull request is complete from my side. It is still needed, and we can merge this pull request.

[amitu]

@Arpita-Jaiswal, @Heulitig, review Ker lo

[amitu]

@harshdoesdev there is no test case using or-type in this PR, can you add one?

[harshdoesdev]

@harshdoesdev there is no test case using or-type in this PR, can you add one?

@amitu I have added an or-type in the test

[amitu]

Did you miss checking in 85-export-or-type.ftd?

[harshdoesdev]

Did you miss checking in 85-export-or-type.ftd?

No, it is an existing test file

[amitu]

@Arpita-Jaiswal, merge it?