Skip waiting for email verification to log the user in #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using BIGSERIAL instead for ids - rename fastn_session to fastn_auth_session
add verified_email to the user_details processor this can be used to, say, show a msg in UI to remind the user to verify their email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are immediately logged in on
create-account. This removes the need of-- auth.email-confirmation-request-sent-page:in some way. A field inuset-details(verified-email) is introduced so frontend can, for example, use it to show a message that reminds the user to "verify their email" if they are unverified. This field also exists onreq.ud().emailandverified_emailfield tofastn_userto avoid sql queries with joins.BIGSERIALfor IDsfastn_sessiontofastn_auth_sessionto avoid confusion. A generalized session store will replace this in future.