Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageGraphic should use tiling if necessarry, get rid of HeatmapGraphic #507

Closed
kushalkolar opened this issue May 20, 2024 · 0 comments · Fixed by #511
Closed

ImageGraphic should use tiling if necessarry, get rid of HeatmapGraphic #507

kushalkolar opened this issue May 20, 2024 · 0 comments · Fixed by #511

Comments

@kushalkolar
Copy link
Member

kushalkolar commented May 20, 2024

The only reason HeatmapGraphic exists is to display images with dims larger than the WGPU max texture size (8192, 8192). _ImageTile just adds the chunk index to the pick_info dict but we can instead just use the chunk indices to set the actual index position of events based on the chunk size.

def _wgpu_get_pick_info(self, pick_value):
pick_info = super()._wgpu_get_pick_info(pick_value)
# add row chunk and col chunk index to pick_info dict
return {
**pick_info,
"row_chunk_index": self.row_chunk_index,
"col_chunk_index": self.col_chunk_index,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant