-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling colors and other modifiable attributes #77
Comments
This seems great I really like it! Would make certain things really intuitive and simple. |
Could also add sizes, at least for scatter, might also be possible for line |
for now thing left to do is sizes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The way colors are handled by
Graphic
is kinda of wonky now, I'm thinking of making a base classGraphicAttribute
which is indexable, this would allow intuitive fine grained color control. It would probably also fix the current wonkyness ofScatterGraphic
.example:
This would basically call
pygfx
geometry/materialcolors.data
and theupdate_range()
for only the indices modified@EricThomson @clewis7 thoughts?
@clewis7 this will get rid of all the current
update_<graphic_attr>
methods, but we can change that later. For interactivity we can just allow anything that is aGraphicAttribute
instance to be a modifiable feature.The text was updated successfully, but these errors were encountered: