Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexable graphic attributes #78

Merged
merged 11 commits into from Dec 23, 2022
Merged

indexable graphic attributes #78

merged 11 commits into from Dec 23, 2022

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Dec 19, 2022

implements #77

GraphicFeatures to implement:

  • colors
  • sizes
  • data - mostly wrap current update_data methods, just pass the slice obj directly to geo.grid or geo.positions, and for positions update_range with indices parsed by slice object, otherwise entire thing with grid.
  • present (different from visibility) - not indexable
  • events for when these change

@kushalkolar
Copy link
Member Author

color indexing is really nice :D

crazy_colors-2022-12-19_04.30.30.mp4

@kushalkolar
Copy link
Member Author

this insanity is possible now: https://www.youtube.com/watch?v=j_gwi-Wf1Ao

also this which is more useful 😄

image

@kushalkolar
Copy link
Member Author

For scatter we can make size an indexable feature too.

@kushalkolar kushalkolar mentioned this pull request Dec 22, 2022
14 tasks
@kushalkolar
Copy link
Member Author

kushalkolar commented Dec 22, 2022

@EricThomson, @clewis7 , @ArjunPutcha
guys this is pretty epic, changing a GraphicFeature can trigger events 😄

Caitlin, pick_info formatting is the same as pygfx events to make life easy :D

features-events-2022-12-22_06.07.58.mp4

Will merge as soon as #61 is ready

@EricThomson
Copy link
Contributor

Nice -- this will make certain other things so much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants