Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile example #495

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Dockerfile example #495

wants to merge 2 commits into from

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Apr 25, 2024

We should make some example dockerfiles, this one builds off of the nvidia cuda docker. It builds python3.11 from source and makes a venv, I think we can just keep this in here because if someone wants to use conda they can just replace that part and adjust the rest accordingly.

I think I should put this in some directory and probably not in the repo root right?

@apasarkar @clewis7 you guys are more experienced with this than me, let me know what you think.

@kushalkolar
Copy link
Member Author

Actually the better way to do this might be to put it on dockerhub with a few variations:

  1. Barebones, only with wgpu
  2. With fastplotlib installed using venv
  3. With fastplotlib and mamba 🤷‍♂️

Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also LGTM

@clewis7
Copy link
Member

clewis7 commented May 31, 2024

Actually the better way to do this might be to put it on dockerhub with a few variations:

  1. Barebones, only with wgpu
  2. With fastplotlib installed using venv
  3. With fastplotlib and mamba 🤷‍♂️

I think the bottom two make sense to give people the option of what they are most comfortable with. I'm not sure if we really need a barebones, I think it would not get used much.

@kushalkolar
Copy link
Member Author

A WGPU docker image could be useful in general for others.

Also is there a way to use github actions to "publish" to docker-hub every time we merge into main and for every release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants