Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sphinx gallery #509
sphinx gallery #509
Changes from 7 commits
22e1c85
71c1eaf
c8eb15d
e97f37b
5e0d08c
1acbbfb
372e466
b4dbc94
0fc05dd
2856365
dacc382
985eb2e
79b6e7f
9c447de
c92e5b7
676a481
09acb24
f749ef3
59ec3fb
d0852f4
7efad6b
16c712c
98d5280
ff3f429
1fba2c4
3ff1982
26d85e4
ea298dc
950d4b4
64aaca7
27c90aa
ee2d8f1
0e199ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specifiy that this line isn't required for users, or see if there's a way for the
pygfx
scraper to look forfig.canvas
instead ofcanvas
?in all examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think perhaps we can use
figure
instead...pygfx
scraper looks for one of["renderer", "canvas"]
to be defined, but will also look through proxy objects such as"figure", "display", "disp", "plot"
So I will try that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried changing
fig
tofigure
so then the scraper would look forfigure.canvas
...but then writing the thumbnails failedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now, we should just to
canvas = fig.canvas
and have a note saying that it is not required for users and after FENS I can look into fixing them