Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cladding Properties to TACOCAT #67

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

thurstonsd
Copy link
Contributor

This addresses issue #62. This is an updated version to run clad_props.py on TACOCAT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be remove, it was only used for testing.

@lcarasik
Copy link
Contributor

lcarasik commented Oct 5, 2023

There is a number of tacocat.py files with the full code, can someone figure out why there is 3 different ones instead of just tacocat.py?

@FranklinTrevor
Copy link
Contributor

I went ahead and removed the extra TACOCAT files. Should be good now for your review @lcarasik

@FranklinTrevor
Copy link
Contributor

All extra files are addressed and this should be good to merge

Added a comma to the last item in the cladding dictionary
Copy link
Collaborator

@sierratutwiler sierratutwiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing I see is that you might need a comma on the last item in the cladding dictionary on line 66 in Clad_Props.py, I went ahead and added the comma and approved.

@lcarasik
Copy link
Contributor

Hey folks,

Sorry can you update this one more time with the other pull request being completed?

@FranklinTrevor FranklinTrevor merged commit da51265 into main Feb 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants