-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cladding Properties to TACOCAT #67
Conversation
TACOCAT-Run CladProps.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be remove, it was only used for testing.
There is a number of tacocat.py files with the full code, can someone figure out why there is 3 different ones instead of just tacocat.py? |
I went ahead and removed the extra TACOCAT files. Should be good now for your review @lcarasik |
All extra files are addressed and this should be good to merge |
Added a comma to the last item in the cladding dictionary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The only thing I see is that you might need a comma on the last item in the cladding dictionary on line 66 in Clad_Props.py, I went ahead and added the comma and approved.
Hey folks, Sorry can you update this one more time with the other pull request being completed? |
This addresses issue #62. This is an updated version to run clad_props.py on TACOCAT