This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Add dual booting configuration to test application with both Rails 6.0 and 6.1 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be necessary for dual booting our app
etagwerker
changed the title
2 tasks
rdormer
approved these changes
Dec 21, 2020
bronzdoc
reviewed
Dec 21, 2020
| @@ -2,12 +2,8 @@ | |||
|
|
|||
| RSpec.describe "todos/index" do | |||
| before do | |||
| controller.singleton_class.class_eval do | |||
There was a problem hiding this comment.
What this change has to do with dual booting?
There was a problem hiding this comment.
@bronzdoc because this does not work with Rails 6.1. I did some research and it is an old idiom recommended by an old version of rspec-rails. It is no longer recommended and it hasn't been recommended in a while.
It was changed 9+ years ago. rspec/rspec-rails#420
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This is a PR to check compatibility between Rails 6.0 and 6.1.
The final goal is to upgrade to rails 6.1.The updated goal is to add dual booting to Circle CI.At the moment it is WIPUpdate: It seems that this repo is quite easy to migrate to Rails 6.1.
I've created an issue to address the upgrade itself: #58
Please check it out.
Thanks!