Support .env.template if no .env.sample #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
commented
Jun 15, 2023
| @@ -73,15 +73,19 @@ For more information check this [page](https://docs.docker.com/compose/environme | |||
| The workaround is to rename your `.env` file when using docker. [Here](https://github.com/bkeepers/dotenv#what-other-env-files-can-i-use) you'll find all naming options acceptable for dotenv and that Docker will not automatically parse. | |||
|
|
|||
| If renaming is not an option, then you need to remove any comments or trailing whitespaces from your `.env` file: | |||
|
|
|||
There was a problem hiding this comment.
sorry, below this line it was just the formatter in this file, I can remove that if needed
JuanVqz
reviewed
Jun 16, 2023
| @@ -4,13 +4,18 @@ | |||
| let(:sample_lines) { StringIO.new("") } | |||
|
|
|||
| before do | |||
| allow(File).to receive(:exist?).and_return(true) | |||
JuanVqz
approved these changes
Jun 16, 2023
etagwerker
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.Description:
This PRs adds a fallback to also support
.env.templateif.env.sampleis not present. The.env.templatefile is created by dotenv itself when using thedotenv -t .envcommand, so it's important to support it since many users of dotenv could be using that instead of.env.sample. https://github.com/bkeepers/dotenv/tree/master#should-i-commit-my-env-fileThis fixes #63
I had to refactor the tests a big to be able to test this better.
I will abide by the code of conduct.