Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing with Ruby 3.2 #67

Merged
merged 9 commits into from Oct 11, 2023
Merged

Fix testing with Ruby 3.2 #67

merged 9 commits into from Oct 11, 2023

Conversation

arielj
Copy link
Contributor

@arielj arielj commented Oct 10, 2023

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description:

This PR updates/fixes the CI tests configuration to test the gem against different Ruby versions.

The 3.0 in the matrix was actually read as 3 which installed Ruby 3.2.2 instead of Ruby 3.0. This PR fixes that by using "3.0" instead and adds an explicit 3.2 element.

(I made the PR on top of the one fixing rubocop to not have rubocop offenses, I can change this if needed)

I will abide by the code of conduct.

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielj Looks good, just one small nitpick

.github/workflows/main.yml Outdated Show resolved Hide resolved
Base automatically changed from fix-rubocop-config to main October 10, 2023 13:34
@arielj arielj merged commit 8de4a4e into main Oct 11, 2023
13 checks passed
@arielj arielj deleted the test-ruby-3-2 branch October 11, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants