Add madmin initial implementation #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toppa
approved these changes
May 9, 2023
| attribute :description | ||
| attribute :real_score | ||
| attribute :extra_info | ||
|
|
There was a problem hiding this comment.
Yes! I don't think it makes a difference for the purpose of this admin panel.
| attribute :id, form: false | ||
| attribute :email | ||
| attribute :sign_in_count, form: false | ||
| attribute :current_sign_in_at |
There was a problem hiding this comment.
I see in the routes that it looks like we only have a show action for individual resources, which makes sense at this stage. Is the idea to include these various sign_in and sign_at fields since they are show only? Just curious.
There was a problem hiding this comment.
I think they add noise, so I'll remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://ombulabs.atlassian.net/browse/DT-443
Motivation / Context
This will give us an easier way to normalize and interconnect our records in the points database.
QA / Testing Instructions
As a user, I should NOT be able to access the /madmin interface.
As an admin, I should be able to access the /madmin interface.
Screenshots:
I will abide by the code of conduct.