Use ombu_labs-auth for authentication #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
commented
Jun 12, 2023
| @@ -1,16 +1,19 @@ | |||
| <%- title = defined?(header_title) ? header_title : "points app" %> | |||
| <%- link = defined?(header_link) ? header_link : "/projects" %> | |||
There was a problem hiding this comment.
we need this because the devise controllers do not extend ApplicationController
etagwerker
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
@arielj Thanks for submitting this! I'll QA it now. Changes look good.
|
@arielj This works as expected. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This replaces #279 using the latest version of the ombu_labs-auth gem.
Motivation / Context
We extracted authentication into a gem to make it easy to share between projects. This project was not using this gem yet.
QA / Testing Instructions
You need to setup the Github related env variables and test that the login is still working.
I could setup the staging environment for this if needed.
I will abide by the code of conduct.