Remove test case using js: true #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://ombulabs.atlassian.net/browse/MKT-582
Motivation / Context
#308
As a feature test, this file
spec/features/projects_manage_spec.rbis defined withjs: trueat the beginning, which makes the action interact with browser and download file locally.This same file at line 139 is testing the same behavior setting
js: false.We also have testing for CSV file content in
spec/controllers/stories_controller_spec.rb:148.QA / Testing Instructions
Run Rspec, check if nothing fails and check if your local 'Download' folder has a .csv file created
CSV file behavior will not change.
Screenshots:
I will abide by the code of conduct.