Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROAD-609: Export approved stories only #324

Merged

Conversation

fbuys
Copy link
Contributor

@fbuys fbuys commented Jan 23, 2024

Jira Ticket

See: https://ombulabs.atlassian.net/browse/ROAD-609

Motivation / Context

We use the CSV tool to export stories to Jira for example. We only want to work on stories that we approved and therefore we only want to export stories from Points that were approved.

QA / Testing Instructions

  • Perform a CSV export in Points (without comments)
  • Take note of the stories and their statuses
  • Ensure that only the approved stories are present in the CSV file.
  • Perform a CSV export in Points (with comments)
  • Take note of the stories and their statuses
  • Ensure that only the approved stories are present in the CSV file.

I will abide by the code of conduct.

@fbuys fbuys requested a review from JuanVqz January 23, 2024 20:11
@fbuys fbuys force-pushed the ROAD-609-dont-export-rejected-pending-stories-in-the-csv-export branch from 54f2758 to 7c51c73 Compare January 23, 2024 20:28
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion related to the expectations

spec/features/projects_manage_spec.rb Outdated Show resolved Hide resolved
spec/controllers/stories_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/stories_controller_spec.rb Outdated Show resolved Hide resolved
@fbuys fbuys force-pushed the ROAD-609-dont-export-rejected-pending-stories-in-the-csv-export branch from 7c51c73 to 230be4d Compare January 24, 2024 15:18
We use the CSV tool to export stories to Jira for example. We only want
to work on stories that we approved and therefore we only want to export
stories from Points that were approved.

See: https://ombulabs.atlassian.net/browse/ROAD-609
@fbuys fbuys force-pushed the ROAD-609-dont-export-rejected-pending-stories-in-the-csv-export branch from 230be4d to 663399e Compare January 24, 2024 15:21
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me :shipit:

Copy link
Contributor

@hmdros hmdros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QAed this, and all that I tested is working as expected!

@fbuys fbuys merged commit a65b85c into main Jan 25, 2024
3 checks passed
@fbuys fbuys deleted the ROAD-609-dont-export-rejected-pending-stories-in-the-csv-export branch January 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants