Fixes/lack of ci

[etagwerker]

Hey,

This PR enables CI for this project. Also, it fixes #2 and fixes #7.

Please check it out.

Thanks!

[cleicar]

Hey @etagwerker did you notice that CI is failing here?

[etagwerker]

@cleicar yeah, I had noticed and that is why I added the wip label 😄

CI is working now and I've created an issue to fix the failure with skunk's action: #9

[bronzdoc]

We want to also add the pull_request event so CI status is reflected in the PR when you open a new PR

on:[push, pull_request]

[bronzdoc]

pull_request too

[bronzdoc]

just curious why this file ends with .github

[etagwerker]

@bronzdoc This file is getting used within the GitHub Actions only, so that is why it has that suffix. It shouldn't be used for anything else.

[etagwerker]

@bronzdoc Just addressed your comments 👍

[etagwerker]

@bronzdoc I don't think it is a great idea to make the events push and pull_request. It seems to run duplicated jobs, which is going to consume more resources than we need. 😕

[bronzdoc]

@etagwerker I gave this a look and I think what we want is:

on:
  push:
    branches:
    - main
  pull_request:
    branches:
    - main

https://github.community/t/how-to-trigger-an-action-on-push-or-pull-request-but-not-both/16662

What you think?

[etagwerker]

@bronzdoc That looks great. Thanks!

[bronzdoc]

@etagwerker it seems there is still an issue in the build, can you have a look?

[etagwerker]

@bronzdoc Are you talking about the Skunk action failure? I added a comment about that over here: #8 (comment)

I see that CI works fine though and this PR was about CI (I meant test suite) not Skunk's GitHub action.