Merge pull request #98 from fastruby/fix-analyzed-module-test

Fix analyzed module test
fastruby · Sep 20, 2022 · 733dd4f · 733dd4f
2 parents b74fe97 + 1e052af
commit 733dd4f
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -31,7 +31,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -46,7 +46,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -61,7 +61,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -76,7 +76,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -91,7 +91,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -101,4 +101,4 @@ jobs:
         run: |
           gem install bundler
           bundle install --jobs 4 --retry 3
-          bundle exec rake
+          bundle exec rake
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## main [(unreleased)](https://github.com/fastruby/skunk/compare/v0.5.2...HEAD)
 
 * <INSERT YOUR FEATURE OR BUGFIX HERE>
+* [BUGFIX: Fix analized module test](https://github.com/fastruby/skunk/pull/98)
+
 ## v0.5.2 / 2022-04-27 [(commits)](https://github.com/fastruby/skunk/compare/v0.5.1...v0.5.2)
 
 * [FEATURE: Support more rubies](https://github.com/fastruby/skunk/pull/92)

diff --git a/lib/skunk/cli/commands/status_reporter.rb b/lib/skunk/cli/commands/status_reporter.rb
@@ -75,7 +75,7 @@ def table_options
         width = max.pathname.to_s.length + HEADINGS_WITHOUT_FILE_WIDTH
         {
           style: {
-            width: width # rubocop:disable Style/HashSyntax
+            width: width
           }
         }
       end

diff --git a/lib/skunk/cli/commands/status_sharer.rb b/lib/skunk/cli/commands/status_sharer.rb
@@ -38,7 +38,6 @@ def base_url
         ENV["SHARE_URL"] || DEFAULT_URL
       end
 
-      # rubocop:disable Style/HashSyntax
       def json_summary
         result = {
           total_skunk_score: total_skunk_score,
@@ -56,7 +55,6 @@ def json_summary
 
         result
       end
-      # rubocop:enable Style/HashSyntax
 
       def json_results
         sorted_modules.map(&:to_hash)

diff --git a/lib/skunk/cli/options/argv.rb b/lib/skunk/cli/options/argv.rb
@@ -37,7 +37,7 @@ def parse # rubocop:disable Metrics/MethodLength
         end
 
         def to_h
-          super.merge(output_filename: output_filename) # rubocop:disable Style/HashSyntax
+          super.merge(output_filename: output_filename)
         end
       end
     end

diff --git a/lib/skunk/rubycritic/analysed_module.rb b/lib/skunk/rubycritic/analysed_module.rb
@@ -53,7 +53,6 @@ def churn_times_cost
     #   - coverage
     #
     # @return [Hash]
-    # rubocop:disable Style/HashSyntax
     def to_hash
       {
         file: pathname.to_s,
@@ -64,6 +63,5 @@ def to_hash
         coverage: coverage.round(2)
       }
     end
-    # rubocop:enable Style/HashSyntax
   end
 end
diff --git a/test/lib/skunk/rubycritic/analysed_module_test.rb b/test/lib/skunk/rubycritic/analysed_module_test.rb
@@ -68,7 +68,9 @@
     end
 
     it "returns a hash with all the attributes and values" do
-      _(@analysed_module.to_hash).must_equal result
+      @analysed_module.stub(:churn, 5) do
+        _(@analysed_module.to_hash).must_equal result
+      end
     end
   end
 end