Some changes for more flexibility downstream #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more control from downstream libraries (power users) on setting the spatially variable 'g' value, than g1 (bedrock) and g2 (sediment).
Allows more flexibility downstream (i.e., use other expressions for computing its value than the one hard-coded in `find_mult_rec`). There is no breaking change.
|
@jeanbraun when you have time could you review these changes? It addresses #24. There is no breaking change. The only change in the API is when a negative value is set for I haven't done any deep checking, but everything compiles and the examples look all good. |
This was referenced Nov 25, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those changes are needed to fully leverage
fastscapelib-fortranin fastscape while enabling more customization.I exploit the fact that all variables declared in
FastScapeContextare exposed to python (i.e., fromfastscapelib_fortran.fastscapecontextattribute), which allows me to do more customization than what is possible by using the API (FastScape_api.f90).