Fix FlowGraph.basins() runtime warning (python) (#147)

* fix flow_graph.basins runtime warning (python) * update release notes
fastscape-lem · Oct 19, 2023 · 052ae70 · 052ae70
1 parent e909637
commit 052ae70
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/doc/source/release_notes.md b/doc/source/release_notes.md
@@ -8,6 +8,8 @@
 
 - Fixed ``pflood_sink_resolver`` that was "flooding too much" ({issue}`145`,
   {pull}`146`).
+- Fixed ``RuntimeWarning`` (invalid value in cast) issued when calling
+  ``FlowGraph.basins()`` in Python ({pull}`147`).
 
 ## v0.2.0 (9 October 2023)
 

diff --git a/include/fastscapelib/flow/flow_graph.hpp b/include/fastscapelib/flow/flow_graph.hpp
@@ -372,7 +372,7 @@ namespace fastscapelib
          */
         data_array_size_type basins()
         {
-            data_array_size_type basins = data_array_type::from_shape(m_grid.shape());
+            data_array_size_type basins = data_array_size_type::from_shape(m_grid.shape());
             auto basins_flat = xt::flatten(basins);
 
             m_impl.compute_basins();