Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first notebooks #1

Merged
merged 3 commits into from
Jan 7, 2021
Merged

first notebooks #1

merged 3 commits into from
Jan 7, 2021

Conversation

jeanbraun
Copy link
Contributor

First download of unfinished versions of the notebooks

@benbovy
Copy link
Member

benbovy commented Jan 7, 2021

@jeanbraun Feel free to merge this pull request so that we can test the docker image once it is merged, built and uploaded.

There's one notebook cell error here but this can be fixed later.

@jeanbraun jeanbraun merged commit 37ab4ec into master Jan 7, 2021
@benbovy benbovy mentioned this pull request Jan 7, 2021
@jeanbraun
Copy link
Contributor Author

@benbovy This has been fixed, as well as another similar error in another notebook

@benbovy
Copy link
Member

benbovy commented Jan 7, 2021

Great! I'm playing with the notebooks right now on my laptop (after having pulled the Docker image), looks like it works well!

There's one issue with the installed version of xarray-simlab that I'll fix (see #4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants