Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatf.utils.data.occlusion.Occlusion.occlude_segments_vectorised removes a dimension for input arrays of shape (1, n) #40

Closed
1 of 3 tasks
So-Cool opened this issue Sep 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@So-Cool
Copy link
Member

So-Cool commented Sep 4, 2022

Please check that you have already viewed existing issues and that the bug you are reporting is new.

Python version

  • 2.x
  • 3.6.x
  • 3.7.11

Package versions

  • fat-forensics: 0.1.1
  • numpy: 1.17.3
  • scipy: 1.4.1

Description

fatf.utils.data.occlusion.Occlusion.occlude_segments_vectorised does not differentiate between an input array of shape (1, n) and (n, ). This is caused by line 648.

Source Code

import fatf.utils.data.occlusion as fatf_occlusion
occluder = fatf_occlusion.Occlusion()
occluder.occlude_segments_vectorised([[1, 1, 1]])
# The output should be of shape (1, ...)
@So-Cool So-Cool added the bug Something isn't working label Sep 4, 2022
So-Cool added a commit that referenced this issue Sep 4, 2022
@So-Cool So-Cool closed this as completed in 5defeca Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant